fix(issues): strip invisible characters from add_issue_comment body#2786
Open
syf2211 wants to merge 2 commits into
Open
fix(issues): strip invisible characters from add_issue_comment body#2786syf2211 wants to merge 2 commits into
syf2211 wants to merge 2 commits into
Conversation
Filter BiDi and other invisible Unicode control characters from issue comment bodies before posting to GitHub. These characters can render as visible separators and break @mentions such as @dependabot rebase. Fixes github#2714
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strip invisible Unicode control characters (especially BiDi isolates) from
add_issue_commentbodies before posting to GitHub.Motivation
Fixes #2714. When MCP clients insert BiDi isolate characters between letters, GitHub can render them as visible middle dots and break
@mentionssuch as@dependabot rebase. Filtering these characters beforeCreateCommentpreserves the intended plain text.Changes
sanitize.FilterInvisibleCharactersto comment bodies inAddIssueCommentbefore calling the GitHub APITests
All tests pass.
Notes
This change is scoped to
add_issue_commentonly. Other comment write tools could receive the same treatment in a follow-up if maintainers want consistency.