fix(discussions): validate required params in read handlers#2785
Open
syf2211 wants to merge 1 commit into
Open
fix(discussions): validate required params in read handlers#2785syf2211 wants to merge 1 commit into
syf2211 wants to merge 1 commit into
Conversation
Return explicit missing-parameter errors from get_discussion and get_discussion_comments instead of silently zero-filling inputs and issuing confusing GraphQL failures. Fixes github#2740
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate required parameters in
get_discussionandget_discussion_commentsbefore issuing GraphQL queries, returning explicitmissing required parametererrors instead of confusing API failures from zero-filled inputs.Motivation
When callers omit
owner,repo, ordiscussionNumber, the read handlers previously usedmapstructure.WeakDecode, which silently substituted zero values and produced GraphQL errors like "Could not resolve to a Repository". The discussion write handlers were updated in #2718 to validate inputs explicitly; the read handlers were missed.Fixes #2740
Changes
mapstructure.WeakDecodewithRequiredParam/RequiredIntinGetDiscussionandGetDiscussionCommentsmapstructureimport fromdiscussions.goowner,repo, anddiscussionNumberon both toolsRequiredIntbehaviorTests
Result: PASS
Notes
discussionNumbervalues (e.g."1") continue to work viaRequiredInt/toInt.owner/reponow fail fast with the same missing-parameter message, matching write-handler behavior.